Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write block tutorial #696
base: main
Are you sure you want to change the base?
Write block tutorial #696
Changes from 5 commits
e4607d8
e6d1b3e
ef73253
88e725f
0a82a42
872ce58
e7ca8c3
0105158
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version of Tiled is this suggested for? With the current most up-to-date Tiled in the main branch I get the following error.
You may want to consider defining
array_client
the following way instead.Also, PEP8:
Finally, for @danielballan, would it be useful to put this part in a utility function and return the
client
for this particular use case (where we know the eventual array size but don't have the full array yet). Then the user can use that client to write chunks in streaming fashion without having to fiddle with the lower levelclient.new()
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. To answer the first part: I am using
tiled == 0.1.0a113
at this moment, and it worked out fine on my local end.I will test the suggested
DataSource
and see if it's compatible with my pipeline. Will follow up on a new comment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up: I went through the release notes, the
DataSource
is introduced in version0.1.0a115
, so within my development environment (0.1.0a113) I was not able to run the suggested code.To accommodate this, I will add both approaches and comment with notes about tiled version. This could serve as a temporary solution until a more advanced high level version come into the play.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should write the tutorial to the most recent version of tiled, given that it is still in alpha.