Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jemalloc support #65

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

piperswe
Copy link
Contributor

@piperswe piperswe commented Mar 30, 2023

jemalloc is often a more optimal memory allocator for Ruby workloads.

@bobvanderlinden
Copy link
Owner

I overlooked this PR. Looks like a good change, thanks! It'll take a while for CI to run.

@bobvanderlinden
Copy link
Owner

Bleh, both ruby-2.3.4 and ruby-2.3.1 are failing the build (tried multiple times 😅). It segfaults during the build:

2023-04-22T22:29:23.3250290Z ruby> generating enc.mk
2023-04-22T22:29:23.3499940Z ruby> /build/ruby-2.3.4/lib/fileutils.rb:1748: [BUG] Segmentation fault at 0x00000000000022
2023-04-22T22:29:23.3502725Z ruby> ruby 2.3.4p301 (2017-03-30 revision 58214) [x86_64-linux]

We can make patches for these specific versions or excempt these versions from being tested.

I'm also fine with not testing this at all. It doubles the build times for new versions and more chances of causing trouble for me maintaining it 😅. If someone wants to use the jemalloc it's their choice, the option is available, but the binaries aren't cached nor tested.

Copy link
Owner

@bobvanderlinden bobvanderlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for ruby-2.3 has been dropped due to other issues. The tests are now passing for all supported versions 👍

@bobvanderlinden bobvanderlinden merged commit 5c55e64 into bobvanderlinden:master Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants