API Service - optional Configuration to every request #41
Conversation
There was a problem hiding this comment.
Thank you very much for your effort. Couple small issues and this should work.
Because of fact that I have no longer access to this repository I cannot push updates to cocoapods.
Please take a look on my fork: RxSwiftAPI, I've rebuild whole core of library which was causing crashes and memory leaks. Also your changes are already there in APILayer. It's still in development but I'm testing it in my current project and is much more stable than old one.
|
|
||
| - Returns: ApiRequest object which allows to follow progress and manage request. | ||
| */ | ||
| func postFile(from localFileUrl: URL, to destinationUrl: URL, with aditionalHeaders: [ApiHeader]? = nil, inBackground: Bool = true, useProgress: Bool = true, completion: ApiResponseCompletionHandler? = nil) -> ApiRequest { | ||
| func postFile(from localFileUrl: URL, to destinationUrl: URL, with aditionalHeaders: [ApiHeader]? = nil, inBackground: Bool = true, useProgress: Bool = true, configuration: ApiService.Configuration = ApiService.Configuration.foreground, completion: ApiResponseCompletionHandler? = nil) -> ApiRequest { | ||
| let configuration: Configuration = inBackground ? .background : .foreground |
There was a problem hiding this comment.
Without removing this line, configuration from method parameter won't be used 😉.
Also inserting configuration as a parameter IMO inBackground is no longer needed.
There was a problem hiding this comment.
That is true! In real i didn't dig that deep, it was just mechanical expansion of every method that had something to do with ApiRequest. Thank you for noticing! Hours of debugging in the future saved! 🥇
The parameter inBackground indeed is not needed when combined with the other
|
|
||
| - Returns: ApiRequest object which allows to follow progress and manage request. | ||
| */ | ||
| func putFile(from localFileUrl: URL, to destinationUrl: URL, with aditionalHeaders: [ApiHeader]? = nil, inBackground: Bool = true, useProgress: Bool = true, completion: ApiResponseCompletionHandler? = nil) -> ApiRequest { | ||
| func putFile(from localFileUrl: URL, to destinationUrl: URL, with aditionalHeaders: [ApiHeader]? = nil, inBackground: Bool = true, useProgress: Bool = true, configuration: ApiService.Configuration = ApiService.Configuration.foreground, completion: ApiResponseCompletionHandler? = nil) -> ApiRequest { | ||
| let configuration: Configuration = inBackground ? .background : .foreground |
|
|
||
| - Returns: ApiRequest object which allows to follow progress and manage request. | ||
| */ | ||
| func patchFile(from localFileUrl: URL, to destinationUrl: URL, with aditionalHeaders: [ApiHeader]? = nil, inBackground: Bool = true, useProgress: Bool = true, completion: ApiResponseCompletionHandler? = nil) -> ApiRequest { | ||
| func patchFile(from localFileUrl: URL, to destinationUrl: URL, with aditionalHeaders: [ApiHeader]? = nil, inBackground: Bool = true, useProgress: Bool = true, configuration: ApiService.Configuration = ApiService.Configuration.foreground, completion: ApiResponseCompletionHandler? = nil) -> ApiRequest { | ||
| let configuration: Configuration = inBackground ? .background : .foreground |
There was a problem hiding this comment.
Thank you very much for your effort. Couple small issues and this should work.
Because of fact that I have no longer access to this repository I cannot push updates to cocoapods.
Please take a look on my fork: RxSwiftAPI, I've rebuild whole core of library which was causing crashes and memory leaks. Also your changes are already there in APILayer. It's still in development but I'm testing it in my current project and is much more stable than old one.
Is it possible to reach you somehow? Please check contact info in my bio
The requests are by default using the Configuration, current changes are introducing custom configuration to every request started from API Service Layer.
For example we can now set timeouts to requests from API Service.