-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 336 protected values hidden #139
base: main
Are you sure you want to change the base?
Conversation
…Content/PropertiesModalContent.tsx Co-authored-by: Tim Bula <[email protected]>
…-io/flow.client.web into feat-336-protectedValuesHidden
@tlawrie @BenjaminRuby So this means I have to change the type from |
Hi @AndreiOla i think the type 'Secured' should only affect the UI, based on previous discussions around not wanting to affect the back end services. But @BenjaminRuby can confirm. |
@BenjaminRuby @AndreiOla how have we gone with this one? |
Moved to draft state per discussion on community call. Needs further coordination with service changes |
Context
Related Issues(s):
boomerang-io/community#336
Build Number:
3.7.73.7.83.7.9Checklist:
PR Review Guidance
Additional Info
Addressing @tlawrie 's comments from merged PR: #138
Did not address 3-6-9, I did not know what additional info to stick in the modal. @tlawrie @timrbula evaluate that as you see fit.
I did update some of the helper texts. I did update the password type in global/team/workflow parameters to be
secured