Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 336 protected values hidden #139

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

BenjaminRuby
Copy link
Member

Context

Related Issues(s):
boomerang-io/community#336
Build Number:
3.7.7 3.7.8 3.7.9

Checklist:

  • Verified in an integrated environment
  • Unit and integration tests passing
  • Semantic HTML with accessibility support
  • No linting, test console, or browser console errors (best effort)
  • JSDoc comment blocks for complex code

PR Review Guidance

Additional Info

Addressing @tlawrie 's comments from merged PR: #138

  • Did not address 3-6-9, I did not know what additional info to stick in the modal. @tlawrie @timrbula evaluate that as you see fit.

  • I did update some of the helper texts. I did update the password type in global/team/workflow parameters to be secured

@BenjaminRuby BenjaminRuby requested review from timrbula and tlawrie May 24, 2022 03:24
@AndreiOla
Copy link

@tlawrie @BenjaminRuby So this means I have to change the type from password to secure? In workflow Java and test JSONs, loader JSONs?

@tlawrie
Copy link
Member

tlawrie commented May 24, 2022

Hi @AndreiOla i think the type 'Secured' should only affect the UI, based on previous discussions around not wanting to affect the back end services.

But @BenjaminRuby can confirm.

@tlawrie
Copy link
Member

tlawrie commented Jun 27, 2022

@BenjaminRuby @AndreiOla how have we gone with this one?

@timrbula timrbula marked this pull request as draft July 19, 2022 20:30
@timrbula
Copy link
Member

Moved to draft state per discussion on community call. Needs further coordination with service changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants