-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modular build structure. #264
Conversation
This implements the required asm functions for sparc64_sysv_elf and was tested on an OpenBSD/sparc64 system. Jump_fcontext uses an extra C call frame to store the frame-pointer and return address. Because of this the code is simply a save (to new reg window), then forcing a window flush and finally switch stack and restore from there. Since jump_fcontext() uses a register window and stack frame, make_fcontext() reserves two call frames on the stack (one for jump_fcontext() and the other for the callback function). OpenBSD/sparc64 uses stackghost which prevents userland from overriding the return-address on the stack. Because of this make_fcontext() uses an extra trampoline to implement the _exit(0) call if the callback returns. All tests pass with this on OpenBSD/sparc64 (also the tests for fiber, coroutine and coroutine2).
Without this test_fcontext.cpp fails on OpenBSD with a not-on-stack OS error.
…a source in install targets.
Please review and merge this PR at your earliest convenience. |
Sorry - some checks are faling (11 failing and 12 successful checks) |
The failures look unrelated to my changes. Especially since the checkout itself is failing. |
Since 463cffe CI builds are broken on some platforms! |
The use of context/build/architecture.jam Line 68 in d11cbcc
Predef probably needs to be fixed. There are three additional failures in multi.yml, but I don't know what they are caused by. Maybe @Kojoley, who wrote multi.yml, would be able to say. |
I'm sorry, I have no idea. Predef could be absolutely in the wrongs, like in this case boostorg/predef#127. But the fundamentals of this project build script is a primary issue and I had too many attempts at improving the situation. |
Did those CI jobs work when you originally wrote multi.yml? We need to figure out what broke them. |
boostorg/predef#135 seems like a likely cause, too. |
OK, the answer is yes, they did work before this PR was merged: https://github.com/boostorg/context/actions/runs/10594678160 |
This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.
This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:
This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.