short circuit serializer::read on empty buffer

boostorg · Oct 30, 2024 · 9b3b993 · 9b3b993
1 parent 7b16bf7
commit 9b3b993
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/include/boost/json/impl/serializer.ipp b/include/boost/json/impl/serializer.ipp
@@ -542,6 +542,9 @@ read(char* dest, std::size_t size)
     if( !fn0_ )
         reset(nullptr);
 
+    if(BOOST_JSON_UNLIKELY(size == 0))
+        return {dest, 0};
+
     detail::stream ss(dest, size);
     if(st_.empty())
         fn0_(*this, ss);

diff --git a/test/serializer.cpp b/test/serializer.cpp
@@ -896,6 +896,10 @@ class serializer_test
     void
     run()
     {
+        {
+            serializer sr;
+            BOOST_ASSERT( sr.read(nullptr, 0).empty() );
+        }
         testNull();
         testBoolean();
         testString();