GPU Batch 12 #1200
Merged
GPU Batch 12 #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SYCL testing of ariy functions Add CUDA testing of airy functions Add NVRTC testing of airy functions Add GPU support to ellint rc Add GPU support to ellint rd Add GPU support to ellint rf Add GPU support to ellint rg Add GPU support to ellint rj Add GPU support to ellint d Add GPU support to ellint_1 Markup forward and add ellint_3 return type def for NVRTC platform Add CUDA testing of ellint 1 NVRTC fixes Add NVRTC testing of ellint_1 Add GPU support to ellint_2 Add CUDA testing of ellint_2 Fix NVRTC errors Add NVRTC testing of ellint_2 Add GPU support to atanh Add GPU support to ellint_3 Add NVRTC testing of ellint_3 Add CUDA testing of ellint_3 Replace use of static const char* Add SYCL testing of ellint_1 Add SYCL testing of ellint 2 with slight tolerance bump Remove recursion from ellint_rj Add ellint_d CUDA testing Add NVRTC testing of ellint_d Add SYCL testing of ellint_d Remove SYCL ellint_3 support Update docs Add GPU support to jacobi zeta Add CUDA testing of jacobi zeta Add NVRTC testing of jacobi zeta Add SYCL testing of jacobi zeta Add GPU support to heuman_lambda Add NVRTC testing of heuman lambda Add CUDA testing of heuman_lambda Add SYCL testing of heuman lambda Add markers to docs Add marker for CUDA only functions in the docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1200 +/- ##
===========================================
- Coverage 93.80% 93.78% -0.02%
===========================================
Files 657 657
Lines 53881 53899 +18
===========================================
+ Hits 50541 50551 +10
- Misses 3340 3348 +8
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the airy functions:
airy_ai,airy_ai_prime,airy_ai_zero,airy_bi,airy_bi_prime,airy_bi_zero, and the entire ellint family:ellint_1,ellint_2,ellint_3,ellint_d,heuman_lambda,jacobi_zeta,ellint_rf,ellint_rd,ellint_rj,ellint_rc, andellint_rg. The only outlier in all of this isellint_3only supports CUDA (NVCC and NVRTC) and is annotated as such, I couldn't quite figure out how to remove all of the recursion to get SYCL running since there are a large number of edge cases handled in the implementation.On device testing can be found here: cppalliance/cuda-math#26
CC: @dschmitz89 , @izaid, @steppi