Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set finalised date to exchanges in other states and add e2e test #595

Conversation

albertfolch-redeemeum
Copy link
Collaborator

No description provided.

@@ -94,53 +95,6 @@ describe("core-sdk", () => {
).toBe(true);
});

describe("deposit funds", () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved code

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #595 (5b5629a) into main (c56c682) will increase coverage by 0.29%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 5b5629a differs from pull request most recent head f2e6291. Consider uploading reports for the commit f2e6291 to get more accurate results

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   84.15%   84.45%   +0.29%     
==========================================
  Files         134      134              
  Lines        4052     4052              
  Branches      712      712              
==========================================
+ Hits         3410     3422      +12     
+ Misses        642      630      -12     
Flag Coverage Δ
common 84.93% <ø> (ø)
core-sdk 50.07% <ø> (ø)
e2e 83.52% <ø> (+0.32%) ⬆️
eth-connect-sdk 18.30% <ø> (ø)
ethers-sdk 67.63% <ø> (ø)
ipfs-storage 94.02% <ø> (ø)
metadata 94.44% <ø> (ø)
unittests 53.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

e2e/tests/core-sdk-funds.test.ts Outdated Show resolved Hide resolved
@albertfolch-redeemeum albertfolch-redeemeum merged commit 59dd479 into main Oct 24, 2023
2 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the 739-seller-locked-funds-is-not-correct-in-finance-dashboard branch October 24, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seller locked funds is not correct in Finance Dashboard
2 participants