Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create/update seller - force clerk to be AddressZero whatever th… #670

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

levalleux-ludo
Copy link
Member

@levalleux-ludo levalleux-ludo commented Feb 20, 2024

…e passed arguments

Description

related to bosonprotocol/interface#1024

How to test

N/A

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a97e98a) 84.74% compared to head (c2fe8d2) 84.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files         144      144           
  Lines        4490     4490           
  Branches      789      789           
=======================================
  Hits         3805     3805           
  Misses        685      685           
Flag Coverage Δ
common 85.11% <ø> (ø)
core-sdk 49.93% <ø> (ø)
e2e 83.13% <ø> (ø)
eth-connect-sdk 18.30% <ø> (ø)
ethers-sdk 67.63% <ø> (ø)
ipfs-storage 90.90% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 54.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant