Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Premint and CreateListing buttons #774

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

levalleux-ludo
Copy link
Member

Description

  • add hooks returning a Signer with ethers-v6 format
  • add PremintButton to allow creating preminted vouchers for a given offer
  • add CreateListingButton to allow listing a preminted voucher

How to test

N/A

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (3ea1c21) to head (595ecf5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files         162      162           
  Lines        6009     6009           
  Branches      915      915           
=======================================
  Hits         5415     5415           
  Misses        594      594           
Flag Coverage Δ
common 92.11% <ø> (ø)
core-sdk 57.82% <ø> (ø)
e2e 87.30% <ø> (ø)
eth-connect-sdk 97.33% <ø> (ø)
ethers-sdk 70.03% <ø> (ø)
ipfs-storage 90.66% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 61.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +95 to +115
// if (isMetaTx) {
// const nonce = Date.now();

// const { to, r, s, v, functionSignature } =
// await coreSdk.signMetaTxPreMint({
// offerId,
// amount: length
// });

// txResponse = await coreSdk.relayNativeMetaTransaction({
// to,
// {
// functionSignature,
// sigR: r,
// sigS: s,
// sigV: v
// }
// });
// } else {
txResponse = await coreSdk.preMint(offerId, preMintAmount);
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be commented out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants