Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getSupportedChainIdsFromWalletConnectSession #855

Merged

Conversation

albertfolch-redeemeum
Copy link
Collaborator

@albertfolch-redeemeum albertfolch-redeemeum commented Nov 22, 2024

@albertfolch-redeemeum albertfolch-redeemeum merged commit 6863857 into main Nov 22, 2024
7 of 9 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the add-getSupportedChainIdsFromWalletConnectSession branch November 22, 2024 12:14
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.99%. Comparing base (c0ce9b9) to head (26b92b9).
Report is 134 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c0ce9b9) and HEAD (26b92b9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (c0ce9b9) HEAD (26b92b9)
unittests 6 5
e2e 1 0
metadata 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #855       +/-   ##
===========================================
- Coverage   90.11%   61.99%   -28.13%     
===========================================
  Files         162      152       -10     
  Lines        6009     5891      -118     
  Branches      915      897       -18     
===========================================
- Hits         5415     3652     -1763     
- Misses        594     2239     +1645     
Flag Coverage Δ
common 92.11% <ø> (ø)
core-sdk 59.50% <ø> (+1.67%) ⬆️
e2e ?
eth-connect-sdk 94.87% <ø> (-2.47%) ⬇️
ethers-sdk 69.62% <ø> (-0.41%) ⬇️
ipfs-storage 89.41% <ø> (-1.26%) ⬇️
metadata ?
unittests 61.99% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant