Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Magnes to 5.4.1 #1115

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Update Magnes to 5.4.1 #1115

merged 3 commits into from
Oct 24, 2023

Conversation

jaxdesmarais
Copy link
Contributor

@jaxdesmarais jaxdesmarais commented Oct 12, 2023 •
edited by scannillo
Loading

Summary of changes

TODO:

  • Once CI is green we will need to update hosted assets with the new version
  • Bump cartfile version once hosted assets are deployed
  • Add CHANGELOG entry

Checklist

  • Added a changelog entry

Authors

@scannillo
Copy link
Contributor

🦵 Kicking CI since the assets should be readily available now at https://assets.braintreegateway.com/mobile/ios/carthage-frameworks/pp-risk-magnes/PPRiskMagnes.json

@scannillo scannillo marked this pull request as ready for review October 18, 2023 15:34
@scannillo scannillo requested a review from a team as a code owner October 18, 2023 15:34
@scannillo scannillo changed the title [DO NOT REVIEW] Update Magnes to 5.4.1 Update Magnes to 5.4.1 Oct 18, 2023
@scannillo
Copy link
Contributor

5.4.1 is now gone again from https://assets.braintreegateway.com/mobile/ios/carthage-frameworks/pp-risk-magnes/PPRiskMagnes.json 😔 - checking in with the Edge team again.

@scannillo scannillo changed the title Update Magnes to 5.4.1 [BLOCKED] Update Magnes to 5.4.1 Oct 18, 2023
@jaxdesmarais jaxdesmarais merged commit 738aaa9 into main Oct 24, 2023
3 checks passed
@jaxdesmarais jaxdesmarais deleted the magnes-stage-removed branch October 24, 2023 15:39
@jaxdesmarais jaxdesmarais changed the title [BLOCKED] Update Magnes to 5.4.1 Update Magnes to 5.4.1 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@sshropshire sshropshire sshropshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staging URLs present in production code - Security Issue - For our Customer
4 participants
@jaxdesmarais @scannillo @sshropshire @sarahkoop