Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Magnes 5.4.1 #1119

Merged
merged 4 commits into from
Oct 30, 2023
Merged

[5.x] Magnes 5.4.1 #1119

merged 4 commits into from
Oct 30, 2023

Conversation

jaxdesmarais
Copy link
Contributor

@jaxdesmarais jaxdesmarais commented Oct 25, 2023

Summary of changes

  • Update 5.x branch with Magnes 5.4.1 security fix (stage URLs removed)
  • This has been tested on Xcode 14.1 to verify backwards compatibility - since Magnes does not use any Swift 5.8 specific features we are covered by Swift's library evolution to be compatible with lower Swift/Xcode versions.

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais
Copy link
Contributor Author

jaxdesmarais commented Oct 25, 2023

We will verify the new version of PPRiskMagnes can be built with Xcode 14.1 + Swift 5.7. Downloading Xcode 14.1 to verify there are no Swift 5.8 specific features built with this release that won't be backwards compatible - if not we should be covered by Swift's Library Evolution.

@jaxdesmarais jaxdesmarais changed the title [DO NOT REVIEW] Magnes 5.4.1 [5.x] Magnes 5.4.1 Oct 26, 2023
@jaxdesmarais jaxdesmarais marked this pull request as ready for review October 26, 2023 14:13
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 26, 2023 14:13
Copy link
Contributor

@sarahkoop sarahkoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending your xcode downgrade confirmation change LGTM

@jaxdesmarais
Copy link
Contributor Author

Pending your xcode downgrade confirmation change LGTM

Already verified this morning (forgot to update the comment and just updated the PR description) so we should be g2g. Everything compiles fine on Xcode 14.1 with Swift 5.7. 🚀

@jaxdesmarais jaxdesmarais merged commit a988028 into 5.x Oct 30, 2023
6 checks passed
@jaxdesmarais jaxdesmarais deleted the magnes-5.4.1 branch October 30, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants