Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V6_MIGRATION Guide #1123

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Update V6_MIGRATION Guide #1123

merged 1 commit into from
Oct 31, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Add BTAppContextSwitcher method name changes to Venmo section

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 31, 2023 14:10
@jaxdesmarais
Copy link
Contributor Author

@scannillo looking through the slack thread in the ticket it mentions the Local Payment snippets being wrong. I think this is expected as that section mentioned the old methods no longer being needed. Here is the snippet in question:

We have renamed the module `BraintreePaymentFlow` to `BraintreeLocalPayment`
We have replaced `SFAuthenticationSession` with `ASWebAuthenticationSession` in the Local Payment Method flow. With this change, you no longer need to:
  * Register a URL Scheme or set a return URL via the `BTAppContextSwitcher.setReturnURLScheme()` method
  * Handle app context switching via the `BTAppContextSwitcher.handleOpenURL(context: UIOpenURLContext)` or `BTAppContextSwitcher.handleOpenURL(URL)`

I oped to add the code changes to the Venmo section instead but let me know if you think something in the LPM section should also be updated. Imo to seems odd to replace the v5 code with v6 code snippets only to say it no longer is needed for LPMs.

Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this one!

@jaxdesmarais jaxdesmarais merged commit b0db748 into main Oct 31, 2023
6 checks passed
@jaxdesmarais jaxdesmarais deleted the update-migration-guide branch October 31, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants