Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Update 5.4.1 Magnes Pt 2 #1127

Merged
merged 5 commits into from
Nov 17, 2023
Merged

[5.x] Update 5.4.1 Magnes Pt 2 #1127

merged 5 commits into from
Nov 17, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • The versions somehow got goofed in the last PR, no idea what version of Magnes we linked since they don't contain the version anywhere, this is actually 5.4.1 with staging removed
  • Can be verified by pulling down this branch and running the following:
    • Navigate to Frameworks/XCFrameworks/PPRiskMagnes.xcframework/ios-arm64_x86_64-simulator/PPRiskMagnes.framework and Frameworks/XCFrameworks/PPRiskMagnes.xcframework/ios-arm64/PPRiskMagnes.framework
    • Run strings PPRiskMagnes | grep "stage"
    • Nothing should be returned
  • The command strings PPRiskMagnes | grep "stage" can also be run for the version linked for Carthage at https://assets.braintreegateway.com/mobile/ios/carthage-frameworks/pp-risk-magnes/PPRiskMagnes.json for version 5.4.1-stage-removed

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner November 2, 2023 14:41
@jaxdesmarais jaxdesmarais changed the title Update 5.4.1 Magnes Pt 2 [5.x] Update 5.4.1 Magnes Pt 2 Nov 2, 2023
@jaxdesmarais
Copy link
Contributor Author

jaxdesmarais commented Nov 2, 2023

Will look into if these failures need to be addressed by us or Magnes

@jaxdesmarais
Copy link
Contributor Author

Will update this PR with the carthage version once that is released

@jaxdesmarais
Copy link
Contributor Author

Carthage cache is still only sometimes working - escalating internally to see why the cache for our assets is so flakey suddenly

@jaxdesmarais
Copy link
Contributor Author

UI test failure is unrelated to this PR. Assets have been stable for 24 hours so we should be good to merge this in.

@jaxdesmarais jaxdesmarais merged commit 50f9daf into 5.x Nov 17, 2023
5 of 6 checks passed
@jaxdesmarais jaxdesmarais deleted the update-5.4.1-magnes branch November 17, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants