Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Old Bridging Headers #1131

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Remove Old Bridging Headers #1131

merged 1 commit into from
Nov 6, 2023

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • We had some old bridging headers in our tests that were no longer needed
    • Removed these files where possible
    • Replaced with imports where needed without bridging headers

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner November 6, 2023 14:40
scannillo
scannillo approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jaxdesmarais jaxdesmarais merged commit 4699a5d into main Nov 6, 2023
6 checks passed
@jaxdesmarais jaxdesmarais deleted the remove-old-header-files branch November 6, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @scannillo @sshropshire