Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate duplicate BTAPIClient HTTP methods #1139

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Consolidate duplicate BTAPIClient HTTP methods #1139

merged 1 commit into from
Dec 4, 2023

Conversation

scannillo
Copy link
Contributor

Summary of changes

  • Remove overload methods for BTAPIClient.post() and BTAPIClient.get()
  • Instead use single method signature for each with default param value for BTAPIClientHTTPService

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner December 1, 2023 17:53
@scannillo
Copy link
Contributor Author

UI tests passing locally

jaxdesmarais
jaxdesmarais approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 this is way cleaner than having the duplicate for 1 param that can instead just be defaulted!

@scannillo scannillo merged commit a9a1eec into main Dec 4, 2023
6 checks passed
@scannillo scannillo deleted the cleanup-api-client-http-methods branch December 4, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scannillo @jaxdesmarais @sshropshire