Allow email OR phone to init BTShopperInsightsRequest
#1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
UI test failures unrelated. Created a JIRA to investigate DTBTSDK-3253 |
sshropshire
reviewed
Dec 7, 2023
sshropshire
approved these changes
Dec 7, 2023
jaxdesmarais
reviewed
Dec 7, 2023
jaxdesmarais
reviewed
Dec 8, 2023
| /// The buyer's country code prefix to the national telephone number. An identifier for a specific country. | ||
| /// Must not contain special characters. | ||
| private let phoneCountryCode: String | ||
| private var email: String? |
There was a problem hiding this comment.
I think we will want these to be internal not private eventually so we can access the properties within the module.
There was a problem hiding this comment.
Hm, maybe let's leave them private until we have to? I'm not sure that we will necessarily
There was a problem hiding this comment.
This type will end up being encoded for the POST to PaymentReady API
There was a problem hiding this comment.
Ah ,gotcha. Yeah we can always change it down the road if needed!
jaxdesmarais
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTShopperInsightsRequestto allow for merchants to pass the following combinations:Note: Tests for this will come once we start constructing the POST json body.
Checklist
Added a changelog entryAuthors
@scannillo