Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shopper Insights Demo feature #1158

Merged
merged 22 commits into from
Dec 15, 2023

Conversation

scannillo
Copy link
Contributor

JIRA DTBTSDK-3174

Summary of changes

  • This PR takes a "path of least resistance" approach and restores the old PreferredPaymentMethods demo feature (see old file)
  • I made only the necessary updates to this file to get it renamed to ShopperInsights & updated for BT iOS V6 API changes
    • Note: This ViewController could use some clean-up, but I figured we can 🏈 punt on it, since we're pretty slammed with feature requests right now (and ShopperInsights will fluctuate a lot the coming weeks)

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner December 12, 2023 17:17
Base automatically changed from shopper-insights-module to payment-insights-feature December 12, 2023 19:33
import BraintreeVenmo
import BraintreeShopperInsights

class ShopperInsightsViewController: PaymentButtonBaseViewController {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to 🏈 on this based on the PR description but subclassing PaymentButtonBaseViewController should allow us to get a lot of this for "free". Specially the createButton and ability to remove the override of the auth init.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is in the Demo app, so not as merchant impacting, but I personally think it's acceptable to take a little time and do this work now. If folks push back we can lean on the company's leadership principles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great callout! Addressed in 92676b6

Copy link
Contributor

@hollabaq86 hollabaq86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, added my two cents on cleanup work now vs later

import BraintreeVenmo
import BraintreeShopperInsights

class ShopperInsightsViewController: PaymentButtonBaseViewController {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is in the Demo app, so not as merchant impacting, but I personally think it's acceptable to take a little time and do this work now. If folks push back we can lean on the company's leadership principles.

@scannillo scannillo merged commit 1eec880 into payment-insights-feature Dec 15, 2023
7 checks passed
@scannillo scannillo deleted the shopper-insights-demo branch December 15, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants