Require Encodable body for all GET requests
#1166
Conversation
| httpRequestWithCaching(method: "GET", path: path, parameters: parameters, completion: completion) | ||
| } else { | ||
| httpRequest(method: "GET", path: path, parameters: parameters, completion: completion) | ||
| func get(_ path: String, parameters: Encodable? = nil, shouldCache: Bool = false, completion: @escaping RequestCompletion) { |
There was a problem hiding this comment.
In a future PR, we can make parameters non-optional, since there are no get() calls in the SDK that don't include this value.
| XCTAssertEqual(lastGetParameters["currencyIsoCode"] as! String, "fake-code") | ||
| XCTAssertEqual(lastGetParameters["paymentMethodNonce"] as! String, "fake-nonce") |
There was a problem hiding this comment.
This work has been a good exercise, since it reveals that we aren't testing the formatting of most our JSON bodies for both GET & POST requests right now 😬 (as also evidenced in #1151)
There was a problem hiding this comment.
I didn't completely understand the example that reveals we aren't testing the formatting of JSON bodies. Maybe understanding it would give me the answer to my question.
Q: Why do we care about the formatting of the JSON as long as the key value pairs are the same?
Great question!
|
| /// The GET parameters for `v1/payment_methods/amex_rewards_balance` | ||
| struct BTAmexRewardsBalanceRequest: Encodable { | ||
|
|
||
| private let currencyIsoCode: String |
There was a problem hiding this comment.
nit for a future PR but we should update this to currencyISOCode to match our style guide preferences. Same in the init
Summary of changes
BTHTTP.get()method to requireEncodablebody instead of raw dictionary paramGETrequests that exist in the SDKBTAmexRewardsBalanceRequestBTConfigurationRequestChecklist
Added a changelog entryAuthors
@scannillo