[DO NOT REVIEW] Fix unit test testLargerMixedJSONWithEmoji() #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmkesselj
changed the title
warmkesselj
changed the title
* Add `BTVenmoRequest.fallbackToWeb`
* If set to true customers will fallback to a web based Venmo flow if the Venmo app is not installed
* This feature has been added to the Demo app, select "Venmo Universal Links" in the Venmo Integration to test this flow
* Add Unit Tests
|
Closing in favor of #1244 since this PR is quite out of date, if we want to take this URL approach instead, lets open a new PR with the BTJSON changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix testLargerMixedJSONWithEmoji().
This test is failing locally because URL(String: String) -> URL? returns a URL even with incorrectly URL formatted Strings. Addicating a REGEX check fixes this problem.
Checklist
Authors