Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CODEOWNERS #15

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Added CODEOWNERS #15

merged 1 commit into from
Sep 27, 2024

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Sep 27, 2024

Part of #12

@wknapik wknapik self-assigned this Sep 27, 2024
@wknapik wknapik requested a review from fmarier September 27, 2024 15:30
@wknapik wknapik enabled auto-merge (squash) September 27, 2024 15:31
@fmarier
Copy link
Member

fmarier commented Sep 27, 2024

Instead of using CODEOWNERS, could we just use the regular review restrictions like we do on brave-core?

i.e. require 1 approving review, and then add as collaborators only the people who should

The main benefits I see is that we don't have another file to maintain, and if I go on holiday, you can still get your PRs reviewed & merged.

@wknapik
Copy link
Collaborator Author

wknapik commented Sep 27, 2024

We require code owner review in brave-core and I'd prefer to have that here as well.

Access to the repo can change over time and a random review is not what we're looking for. This repo will be very sensitive, so I'd prefer to take every precaution.

In the long run, I'd also add the security team and (part of) the devops team as code owners. Can't do that now, while the repo is in brave-experiments.

@wknapik wknapik merged commit b0e3ceb into main Sep 27, 2024
1 check passed
@wknapik wknapik deleted the wknapik-add-codeowners branch September 27, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants