Release edits for cromshell2 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GNU grep doesn't like to work with tabs, so it wasn't properly parsing the aliases out. Removed the offending grep command so aliases can be pulled from the TSV file on linux. - Fixes #135
* Added the sub-command "update-server" Co-authored-by: Stephen Fleming <[email protected]>
* Minor change to remove temp files in the notify helper. - This fixes an issue found where cromshell was filling /tmp disk space with the `notify` daemon. Not 100% sure why the trap didn't catch the temp files, but this fixes it.
* Added commands to calculate the cost for workflows (GCS backend only).
* adding completions for cost/cost-detailed
* Improve formatting of readme for new cost commands * Add forgotten "update-server" command to completions * Add completions/reload.sh script to help developing zsh completions
* Updating wait time for cost from 8h to 24h * Fixing cost wait message to include more information. * Fixed user message.
* timing was putting an extra "http" into the url which caused it to not load correctly. * fixes #167
* Add the ability to pass request headers to the curl command by specifying the "CROMSHELL_HEADER" environment variable. * Useful for passing oauth tokens.
Added docs for CROMSHELL_HEADER env variable
- Fixed problem in task parsing where if a task had the word `Failed` in it, it would be labeled as a failing task regardless of status.
* add a note about cromshell 2 alpha to the master branch readme so people know it exists and how to find it.
…2022 Aug 11 (#219) * Updated `_PARTITIONTIME` to `partition_time` as per SADA billing changes. * Fixing parsing error in `cost-detailed` function.
…inor edits to README.md
bshifaw
commented
Apr 18, 2023
| # cromshell | ||
| A CLI for submitting workflows to a cromwell server and monitoring / querying their results. | ||
| # Cromshell | ||
| [](https://badge.fury.io/gh/broadinstitute%2Fcromshell) |
There was a problem hiding this comment.
Replaced the "Current version:..." wording with a version badge. There are other badges that can be added later like coverage
lbergelson
approved these changes
Apr 25, 2023
README.md
Outdated
| # Cromshell | ||
| [](https://badge.fury.io/gh/broadinstitute%2Fcromshell) | ||
| [](https://github.com/broadinstitute/cromshell/actions/workflows/integration_tests.yml/badge.svg) | ||
| [](https://github.com/broadinstitute/cromshell/actions/workflows/unit_tests.yml/badge.svg) |
There was a problem hiding this comment.
This is called integration workflow twice, I think one is unit test?
README.md
Outdated
| @@ -90,19 +84,19 @@ functions as Cromshell 1 but has been rebuilt in python with many added benefits | |||
|
|
|||
| #### Get email notification on job completion | |||
There was a problem hiding this comment.
Should we pull this from the readme for now?
bshifaw
commented
Apr 25, 2023
added 4 commits
April 28, 2023 10:14
# Conflicts: # README.md
…cript to legacy_cromshell folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cromshellinstead ofcromshell-beta--cu