Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Command fix #256

Merged
merged 3 commits into from
May 2, 2023
Merged

Version Command fix #256

merged 3 commits into from
May 2, 2023

Conversation

bshifaw
Copy link
Collaborator

@bshifaw bshifaw commented May 1, 2023

The version command currently only displays the version of cromshell through Logger.info, but the logger by default is set to show only warnings/errors.

This fix is to have the version command print the version and add unit/integration test for the command.

@bshifaw bshifaw added the bug Something isn't working label May 1, 2023
@bshifaw bshifaw added this to the Cromshell2.1 milestone May 1, 2023
@bshifaw bshifaw self-assigned this May 1, 2023
@bshifaw bshifaw added the Cromshell 2 Issues related to Cromshell 2.0 label May 1, 2023
@bshifaw bshifaw marked this pull request as ready for review May 1, 2023 18:44
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Printing is the right move when someone is explicitly asking for the info.

@bshifaw bshifaw merged commit bac0a28 into main May 2, 2023
@bshifaw bshifaw deleted the bs_print_version branch May 2, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cromshell 2 Issues related to Cromshell 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants