-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated version bump and deployment #257
Conversation
@@ -8,11 +8,10 @@ tag_name = {new_version} | |||
search = version = "{current_version}" | |||
replace = version = "{new_version}" | |||
|
|||
[bumpversion:file:README.md] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed because the version number in Readme is now being automatically displayed by GitHub badges
.github/workflows/ci_main.yml
Outdated
|
||
name: CI/CD | ||
on: | ||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this workflow dispatch
- input would be whether its patch, minor, major for bumpversion
.github/workflows/ci_main.yml
Outdated
# This workflow will run action below on every push to the main branch. | ||
|
||
name: CI/CD | ||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets change this to only happen manually.
…clude input for git release notes and bump version type
… action tool path
.github/workflows/pypi_packaging.yml
Outdated
tag_name: ${{ steps.version-bump.outputs.new_ver }} | ||
release_name: '${{ steps.version-bump.outputs.new_ver }}' | ||
body_path: "release_notes.txt" | ||
draft: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it default to creating a draft release so that someone can manually review the release notes before publishing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bshifaw This looks great to me, one preference on my end would be to have it make the release a draft so that the releaser can manually fix up release notes if they need to. I
Added a CI/CD actionthat gets executed when pushing changes to the master. Includes the following job: