Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated version bump and deployment #257

Merged
merged 14 commits into from
Jun 30, 2023
Merged

Automated version bump and deployment #257

merged 14 commits into from
Jun 30, 2023

Conversation

bshifaw
Copy link
Collaborator

@bshifaw bshifaw commented May 1, 2023

Added a CI/CD actionthat gets executed when pushing changes to the master. Includes the following job:

  • Bump Version - This job will bump the version number by one minor version, in the files listed in .bumpversion.cfg, and push the changes to the main branch. Thus, when a PR is merged into the main branch, the version number will be bumped.
  • Creates a Github release based on the last commit message added to main
  • Builds and pushes patch version to PYPI. currently set to project "cromshell-draft-release" but would be updated to cromshell

@@ -8,11 +8,10 @@ tag_name = {new_version}
search = version = "{current_version}"
replace = version = "{new_version}"

[bumpversion:file:README.md]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because the version number in Readme is now being automatically displayed by GitHub badges

@bshifaw bshifaw changed the title Bs add version bump automated add version bump May 1, 2023
@bshifaw bshifaw changed the title automated add version bump Automated version bump May 1, 2023
@bshifaw bshifaw marked this pull request as ready for review May 1, 2023 18:44
@bshifaw bshifaw self-assigned this May 1, 2023
@bshifaw bshifaw changed the title Automated version bump Automated version bump and deployment May 5, 2023

name: CI/CD
on:
push:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this workflow dispatch

  • input would be whether its patch, minor, major for bumpversion

# This workflow will run action below on every push to the main branch.

name: CI/CD
on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets change this to only happen manually.

bshifaw added 2 commits June 27, 2023 21:54
tag_name: ${{ steps.version-bump.outputs.new_ver }}
release_name: '${{ steps.version-bump.outputs.new_ver }}'
body_path: "release_notes.txt"
draft: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it default to creating a draft release so that someone can manually review the release notes before publishing them?

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bshifaw This looks great to me, one preference on my end would be to have it make the release a draft so that the releaser can manually fix up release notes if they need to. I

@bshifaw bshifaw merged commit 52e6cb6 into main Jun 30, 2023
@bshifaw bshifaw deleted the bs_add_version_bump branch June 30, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants