Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAWB-3840: add test to check reader can see published dataset #1490

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

GAWB-3840: add test to check reader can see published dataset #1490

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f66a9a
add test to check reader can see published dataset
ahaessly Jan 3, 2019
f7bd5cd
use discoverable by group that doesn't exist
ahaessly Jan 15, 2019
9766bb0
update group to allowable type
ahaessly Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion automation/src/test/scala/org/broadinstitute/dsde/firecloud/test/library/PublishSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package org.broadinstitute.dsde.firecloud.test.library

import org.broadinstitute.dsde.firecloud.FireCloudConfig
import org.broadinstitute.dsde.firecloud.fixture.{LibraryData, UserFixtures}
import org.broadinstitute.dsde.workbench.service.Orchestration
import org.broadinstitute.dsde.workbench.service.{AclEntry, Orchestration, WorkspaceAccessLevel}
import org.broadinstitute.dsde.firecloud.page.library.DataLibraryPage
import org.broadinstitute.dsde.firecloud.page.workspaces.summary.WorkspaceSummaryPage
import org.broadinstitute.dsde.workbench.auth.AuthToken
Expand Down Expand Up @@ -78,6 +78,30 @@ class PublishSpec extends FreeSpec with WebBrowserSpec with UserFixtures with Wo
}
}
}
"should be visible to a user that has read access to the workspace but is not in the discoverability group" in {
val curatorUser = UserPool.chooseCurator
val wsReaderUser = UserPool.chooseStudent
implicit val curatorAuthToken: AuthToken = curatorUser.makeAuthToken()
withCleanBillingProject(curatorUser) { billingProject =>
withWorkspace(billingProject, "PublishSpec_reader_view_", aclEntries = List(AclEntry(wsReaderUser.email, WorkspaceAccessLevel.Reader))) { wsName =>
val data = LibraryData.metadataBasic + ("library:datasetName" -> wsName)
api.library.setLibraryAttributes(billingProject, wsName, data)
api.library.setDiscoverableGroups(billingProject, wsName, List("all_broad_users"))
api.library.publishWorkspace(billingProject, wsName)

withWebDriver { implicit driver =>
withSignIn(wsReaderUser) { _ =>
val page = new DataLibraryPage().open
eventually {
page.doSearch(wsName)
page.hasDataset(wsName) shouldBe true
}
}
}
}
}
}


"when cloned" - {
"should be cloned without copying the published status" in {
Expand Down