Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose-setup.sh to use GAR (SCP-5153) #378

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bistline
Copy link
Contributor

@bistline bistline commented Jan 8, 2025

BACKGROUND & CHANGES

Similar to broadinstitute/single_cell_portal_core#2187, this updates any gcloud commands that used Container Registry to now use Artifact Registry. This is part of the mandatory switchover that must be completed by the end of March 2025.

MANUAL TESTING

  1. Ensure Docker is running
  2. Go to the project directory and run the docker-compose-setup.sh script, confirming you are left inside the running Docker container:
$ scripts/docker-compose-setup.sh 
...
Listing items under project broad-singlecellportal-staging, location us, repository gcr.io.

### SETTING UP ENVIRONMENT ###
704fa3f: Pulling from broad-singlecellportal-staging/scp-ingest-pipeline-development
Digest: sha256:004e30bb0c98e31f17e707ac2a391f8ce320823d3bbde568db534c739013d32f
Status: Image is up to date for gcr.io/broad-singlecellportal-staging/scp-ingest-pipeline-development:704fa3f
gcr.io/broad-singlecellportal-staging/scp-ingest-pipeline-development:704fa3f
...

root@068c1a08ccae:/scp-ingest-pipeline/ingest# 

Note: if you receive a scripts/docker-compose-setup.sh: line 60: docker-compose: command not found error, run the remediation steps listed at https://docs.docker.com/compose/install/ regarding the issue with docker-compose in versions after 4.23.

@bistline bistline requested review from eweitz and jlchang January 8, 2025 16:42
@bistline
Copy link
Contributor Author

bistline commented Jan 8, 2025

Build failure for minify ontologies fixed in #377

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (704fa3f) to head (dccb571).
Report is 2 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #378   +/-   ##
============================================
  Coverage        75.79%   75.79%           
============================================
  Files               30       30           
  Lines             4470     4470           
============================================
  Hits              3388     3388           
  Misses            1082     1082           

Copy link
Collaborator

@jlchang jlchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer to the docker-compose fix. Once I updated that symlink, everything worked as described :)

@bistline bistline merged commit 4930f0e into development Jan 13, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants