VS Code: prevent shift+enter keybind conflicts #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses Issue 16. Tightens up scope of when the editor.action.codeAction command fires from keybinding. More restrictive keybinding (use alt as well) since shift+enter is very common. Adds when clauses so only happens when editor has focus and language is wdl.
dinvlad
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16.
Tightens up scope of when the editor.action.codeAction command fires from keybinding.
More restrictive keybinding (use alt as well) since shift+enter is very common.
Adds when clauses so only happens when editor has focus and language is wdl.
[My motivation for this was specifically because it was breaking "Find Previous" (which also uses shift+enter) due to the fact that wdl-ide keybindings have precedence because they're an Extension.]