Fix linter errors #288
Open
Fix linter errors #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a large chunk of the linter errors.
I've ignored/disabled a few linter rules that I think are either excessive or unable to resolve quickly.
Many of the linter errors were about resource ID's not being final and that they should not be used in switch statements, so I refactored the code to use if/else statements.
Some linter errors were about simple string formatting issues, which I've fixed.
Many linter errors were about
String.format()defaulting to the user's locale, which is undesirable if the output is being fed into something such as an API/database/machine interface.I understand that maybe you don't want these errors fixed, and that this PR may take a long time to review + test.
I also noticed that during testing, after the user creates a new profile, hitting the "OK" button on the "New Profile Created" dialog message did not close the message. I thought was confusing, so I've changed the code so that hitting the OK button on the "New Profile Created" popup now results in the intro fragment being "done" and taking the user to the main page.
Let me know your thoughts on this.