fix: innerView와 viewModel 간의 사이클 없앰

bside-tinkerbell · Mar 5, 2024 · acea3b2 · acea3b2
1 parent 9fec9f2
commit acea3b2
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/Waving-iOS/Presentation/Friends/View/FriendsAddView.swift b/Waving-iOS/Presentation/Friends/View/FriendsAddView.swift
@@ -8,9 +8,9 @@
 import UIKit
 import Combine
 
-class FriendsAddView: UIView, SnapKitInterface {
+final class FriendsAddView: UIView, SnapKitInterface {
 
-    var viewModel: FriendsViewModelRepresentable?
+    weak var viewModel: FriendsViewModelRepresentable?
 
     private let containerView: UIView = {
         let view = UIView()

diff --git a/Waving-iOS/Presentation/Friends/View/FriendsDisconnectView.swift b/Waving-iOS/Presentation/Friends/View/FriendsDisconnectView.swift
@@ -9,9 +9,9 @@
 import UIKit
 import Combine
 
-class FriendsDisconnectView: UIView, SnapKitInterface {
+final class FriendsDisconnectView: UIView, SnapKitInterface {
 
-    var viewModel: FriendsViewModelRepresentable?
+    weak var viewModel: FriendsViewModelRepresentable?
 
     private let containerView: UIView = {
         let view = UIView()

diff --git a/Waving-iOS/Presentation/Friends/View/FriendsIntroView.swift b/Waving-iOS/Presentation/Friends/View/FriendsIntroView.swift
@@ -8,9 +8,9 @@
 import UIKit
 import Combine
 
-class FriendsIntroView: UIView, SnapKitInterface {
+final class FriendsIntroView: UIView, SnapKitInterface {
 
-    var viewModel: FriendsViewModelRepresentable?
+    weak var viewModel: FriendsViewModelRepresentable?
 
     private let containerView: UIView = {
         let view = UIView()

diff --git a/Waving-iOS/Presentation/Friends/View/FriendsListView.swift b/Waving-iOS/Presentation/Friends/View/FriendsListView.swift
@@ -10,7 +10,7 @@ import Combine
 
 final class FriendsListView: UIView, SnapKitInterface {
 
-    var viewModel: FriendsViewModelRepresentable?
+    weak var viewModel: FriendsViewModelRepresentable?
     private var friendsList = [GetFriendsEntity]()
 
     let scrollView = UIScrollView()

diff --git a/Waving-iOS/Presentation/Friends/ViewModel/FriendsViewModel.swift b/Waving-iOS/Presentation/Friends/ViewModel/FriendsViewModel.swift
@@ -36,7 +36,7 @@ protocol FriendViewRepresentable where Self: UIView {
     func setup(with viewModel: FriendsViewModelRepresentable, with friendsList: [GetFriendsEntity])
 }
 
-protocol FriendsViewModelRepresentable {
+protocol FriendsViewModelRepresentable: AnyObject {
     func addFriends()
     func didTapBackButton()
     func didTapProfile()

diff --git a/Waving-iOS/Presentation/MainTabBar/ViewController/FriendsViewController.swift b/Waving-iOS/Presentation/MainTabBar/ViewController/FriendsViewController.swift
@@ -46,7 +46,7 @@ final class FriendsViewController: UIViewController, SnapKitInterface {
         return view
     }()
 
-    private var innerView: FriendViewRepresentable?
+    private weak var innerView: FriendViewRepresentable?
 
     override func viewDidLoad() {
         addComponents()
@@ -59,7 +59,7 @@ final class FriendsViewController: UIViewController, SnapKitInterface {
         binding()
     }
 
-    deinit {
+    override func viewDidDisappear(_ animated: Bool) {
         innerView?.removeFromSuperview()
     }