Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "The POST and query parameters of KrakenSpotBaseAPI and KrakenFuturesBaseAPI are not proper encoded in some case" #189

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Feb 20, 2024

In February 2024, Kraken Kraken changed the way of validating payloads, which cased some tests of the scheduled workflow to fail. So I re-evaluated the whole encoding stuff. Together with "Peter" from the Kraken team, I found the route source of error and applied the required changes to fix those issues.

  • fix the encoding for Futures
  • improve encoding for Spot
  • fix typos
  • update pre-commit hooks

@btschwertfeger btschwertfeger added this to the Future Release milestone Feb 20, 2024
@btschwertfeger btschwertfeger self-assigned this Feb 20, 2024
@btschwertfeger btschwertfeger marked this pull request as draft March 8, 2024 15:16
@btschwertfeger btschwertfeger changed the title Fix futures trade tests Resolve "The POST and query parameters of KrakenSpotBaseAPI and KrakenFuturesBaseAPI are not proper encoded in some case" Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.46%. Comparing base (55e7e0a) to head (0f6522b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   89.73%   89.46%   -0.28%     
==========================================
  Files          21       21              
  Lines        1890     1879      -11     
==========================================
- Hits         1696     1681      -15     
- Misses        194      198       +4     
Flag Coverage Δ
unittests 89.46% <94.73%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/futures/__init__.py 100.00% <100.00%> (ø)
kraken/futures/trade.py 94.93% <ø> (-1.27%) ⬇️
kraken/futures/user.py 48.48% <ø> (ø)
kraken/futures/websocket/__init__.py 88.27% <100.00%> (ø)
kraken/futures/ws_client.py 87.50% <ø> (ø)
kraken/spot/__init__.py 100.00% <ø> (ø)
kraken/spot/funding.py 46.57% <ø> (ø)
kraken/spot/market.py 100.00% <ø> (ø)
kraken/spot/orderbook_v1.py 94.44% <ø> (ø)
kraken/spot/orderbook_v2.py 94.04% <ø> (ø)
... and 7 more

@btschwertfeger btschwertfeger marked this pull request as ready for review March 8, 2024 20:44
@btschwertfeger btschwertfeger merged commit 3f53ec7 into master Mar 8, 2024
32 checks passed
@btschwertfeger btschwertfeger deleted the fix-futures-trade-tests branch March 8, 2024 20:44
btschwertfeger added a commit that referenced this pull request Mar 12, 2024
…nFuturesBaseAPI are not proper encoded in some case" (#189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant