Delegate first class spans to native SDK when attached #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid repeated calls to the native module by calling initialise once on module load and getting all of the native settings at once
This partially reverts commit 0820748.
…early spans logic into span factory
Browser bundle sizeNPM build
CDN build
Code coverage
Total:
Generated against c925489 on 6 January 2025 at 12:09:00 UTC |
yousif-bugsnag
force-pushed
the
PLAT-12944/native-first-class-spans
branch
5 times, most recently
from
d165e50 to
3ad1c0f
Compare
yousif-bugsnag
force-pushed
the
PLAT-12944/native-first-class-spans
branch
from
3ad1c0f to
97aeffe
Compare
gingerbenw
reviewed
Jan 6, 2025
gingerbenw
approved these changes
Jan 6, 2025
yousif-bugsnag
merged commit 7d25f48
into
integration/rn-native-integration
43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Delegates the creation and processing of first class spans in React Native to the native Android/Cocoa Performance SDK when attached.
Design
If a native SDK is running and attached (by calling
BugsnagPerformance.attach), first-class spans are started, processed and discarded in the native SDK.JS spans that are backed by a native span are wrapped in a
NativeSpanInternalclass to distinguish them from regular JS spans.Refactored the core start logic so that the span factory is configured synchronously as soon as start is called - this is so that
onSpanEndcallbacks can be applied to spans started immediately afterattachis called. Note that any first class spans started beforeattachis called will not be delegated and will be started/processed in JS.Testing