Add failed driver guard to FileManager Appium API #709
+142
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twometresteve
force-pushed
the
tms/file-manager-guard
branch
from
85eaa21 to
d3773ed
Compare
Cawllec
reviewed
Jan 9, 2025
lib/maze/api/appium/file_manager.rb
Outdated
| @@ -45,7 +61,15 @@ def read_app_file(filename, directory = nil) | |||
| end | |||
|
|
|||
| $logger.trace "Attempting to read file from '#{path}'" | |||
| file = @driver.pull_file(path) | |||
| @driver.pull_file(path) | |||
| true | |||
There was a problem hiding this comment.
Since this is attempting to retrieve a file this should be the file pulled rather than the success metric?
There was a problem hiding this comment.
Gosh, you're absolutely right - I'd assumed the file is written straight to file, but it is returned in memory by the method call. Good spot.
Cawllec
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add failed driver guard to FileManager Appium API.
Design
First of a number of PRs to shift logic away from
Maze::Appium::Driverand protect clients from noise caused by a failed underlying Appium driver.Tests
Unit test added and some local testing performed, but further testing will be performed on the integration branch prior to release.