Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor carry timeout, formula letters, fixes and doc nitpicks #10

Open
wants to merge 11 commits into
base: maccel-dev
Choose a base branch
from
Open

Minor carry timeout, formula letters, fixes and doc nitpicks #10

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39c6a97
doc(maccel) explain Debug-enable sample code
ankostis Mar 10, 2024
51f1691
doc(maccel) explain why low DPIs need throttling >
ankostis Mar 10, 2024
6f56b7b
doc(maccel) denote letter-symbols & and desmos on sample params
ankostis Mar 2, 2024
b8662f3
feat(maccel) stabilize debug print float widths
ankostis Mar 2, 2024
ec76f8b
feat(maccel) debug-dump V as diffs to view carry at work and >
ankostis Mar 2, 2024
9f9693b
fix(maccel) don't dump param-keys if DEBUG is off
ankostis Mar 4, 2024
e8c6d29
feat(maccel) don's reset rounding carry if not stationary
ankostis Mar 3, 2024
1d285de
refact(maccel) demote timer from module-static -> function, >
ankostis Mar 11, 2024
0817331
refact(maccel) explain x1000 factor as curve-fitting, >
ankostis Mar 12, 2024
e164bc3
feat(maccel) debug-dump D as diffs to hook the eye on 0s
ankostis Mar 12, 2024
426ba61
style(maccel) minor comment move
ankostis Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maccel/maccel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ report_mouse_t pointing_device_task_maccel(report_mouse_t mouse_report) {
#ifdef MACCEL_DEBUG
const float distance_out = sqrtf(x * x + y * y);
const float velocity_out = velocity * maccel_factor;
printf("MACCEL: DPI:%5i Tko:%6.3f Grw:%6.3f Ofs:%6.3f Lmt:%6.3f | Acc:%7.3f V.in:%7.3f V.out:%+8.3f D.in:%3i D.out:%3i\n", device_cpi, g_maccel_config.takeoff, g_maccel_config.growth_rate, g_maccel_config.offset, g_maccel_config.limit, maccel_factor, velocity, velocity_out - velocity, CONSTRAIN_REPORT(distance), CONSTRAIN_REPORT(distance_out));
printf("MACCEL: DPI:%5i Tko:%6.3f Grw:%6.3f Ofs:%6.3f Lmt:%6.3f | Acc:%7.3f V.in:%7.3f V.out:%+8.3f D.in:%3i D.out:%+8.3f\n", device_cpi, g_maccel_config.takeoff, g_maccel_config.growth_rate, g_maccel_config.offset, g_maccel_config.limit, maccel_factor, velocity, velocity_out - velocity, CONSTRAIN_REPORT(distance), distance_out - CONSTRAIN_REPORT(distance));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote @Wimads:

debug-dump D-diffs: don't accept. Same as V-diffs.

I do not have a strong opinion on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will separate it in x2 commits, one capitalizing letters, another one showing the outputs as ± diffs.

You really have to run the code to judge the change, by watching the debug-print as you slowly move the mouse to see wether you like the results.
In the end, whether the label precisely describes the value or not is less of importance that helping us tune the curve parameterss.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make it V.diff instead of V.out? That would seem more intuitive to me.

#endif // MACCEL_DEBUG

// report back accelerated values
Expand Down