compilation_on_android.yml: Add shared lib build #3975
Conversation
midokura-xavi92
force-pushed
the
ci-shared
branch
2 times, most recently
from
a2215b4 to
492ccc6
Compare
midokura-xavi92
force-pushed
the
ci-shared
branch
from
492ccc6 to
f1f8c32
Compare
midokura-xavi92
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
|
Are we planning to include a shared library in the final set of release binaries, or are we going to test the compilation of a shared library with each PR? If it's the former, then modifying build_iwasm_release.yml makes sense. However, if it's the latter, you might want to make changes to .github/workflows/compilation_on_* instead. |
I do not decide which artifacts should be built for release, so I assume the latter only for now. I will then update the PR to only modify |
|
@midokura-xavi92 I noticed that the PR has been inactive for a few weeks. It looks like it’s almost ready to be merged, and it would be great to see it completed. Would you be able to make the necessary modifications? If you need any help or have any questions, please feel free to reach out. Your contribution is highly appreciated! |
midokura-xavi92
force-pushed
the
ci-shared
branch
from
c2bde38 to
3f02bc4
Compare
|
@lum1n0us I have just updated the branch so as to modify |
midokura-xavi92
changed the title
| @@ -136,6 +137,7 @@ jobs: | |||
| $LLVM_LAZY_JIT_BUILD_OPTIONS, | |||
| $LLVM_EAGER_JIT_BUILD_OPTIONS, | |||
| $MULTI_TIER_JIT_BUILD_OPTIONS, | |||
| $SHARED_BUILD_OPTIONS, | |||
There was a problem hiding this comment.
not here. this is for variant running mode only.
There was a problem hiding this comment.
You might want to add SHARED_BUILD_OPTIONS into make_options_feature. It will test SHARED_BUILD_OPTIONS with all kinds of running mode
There was a problem hiding this comment.
The change made at line 139 should be undone. That section is intended solely for the run mode configuration.
| @@ -189,6 +191,8 @@ jobs: | |||
| make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1" | |||
| - make_options_run_mode: $MULTI_TIER_JIT_BUILD_OPTIONS | |||
| make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1" | |||
| - make_options_run_mode: $SHARED_BUILD_OPTIONS | |||
| make_options_feature: "-DWAMR_BUILD_DEBUG_INTERP=1" | |||
There was a problem hiding this comment.
not here neither. this usually mean some features are not supported by special running mode
So far, no workflows would attempt to build the shared version of the iwasm library (namely, vmlib). Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS, the actual default options defined by the build system are assumed, for the sake of simplicity and avoiding repeated code.
midokura-xavi92
force-pushed
the
ci-shared
branch
from
3f02bc4 to
f8eba68
Compare
|
Thanks for the tips, @lum1n0us . Please let me know whether the changes are valid now. |
So far, no workflows would attempt to build the shared version of the iwasm library (namely, vmlib).
Note that, as opposed to GC_EH_BUILD_OPTIONS and DEFAULT_BUILD_OPTIONS, the actual default options defined by the build system are assumed, for the sake of simplicity and avoiding repeated code.