add component-model-async/fused.wast test #10106
Open
+1,463
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
force-pushed
the
async-fused-test
branch
2 times, most recently
from
ecd9754 to
7e41099
Compare
This is another piece of bytecodealliance#9582 which I'm splitting out to make review easier. This test exercises fused adapter generation for various flavors of intercomponent async->async, async->sync, and sync->async calls. The remaining changes fill in some TODOs to make the test pass. Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
async-fused-test
branch
from
7e41099 to
098bd1c
Compare
Comment on lines
+284
to
+310
| let params = self.types[self.signature] | ||
| .unwrap_func() | ||
| .params() | ||
| .iter() | ||
| .map(|&v| { | ||
| Some(match v { | ||
| WasmValType::I32 => FlatType::I32, | ||
| WasmValType::I64 => FlatType::I64, | ||
| WasmValType::F32 => FlatType::F32, | ||
| WasmValType::F64 => FlatType::F64, | ||
| _ => return None, | ||
| }) | ||
| }) | ||
| .collect::<Option<_>>(); | ||
|
|
||
| let ty = self.builder.ins().iconst( | ||
| ir::types::I32, | ||
| i64::from( | ||
| params | ||
| .and_then(|params| { | ||
| self.types | ||
| .get_task_return_type(&TypeTaskReturn { params }) | ||
| .map(|v| v.as_u32()) | ||
| }) | ||
| .unwrap_or(u32::MAX), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Two things on this:
- For
let params = ...above, it's unclear to me what this is doing. For example I'm not sure why this would switch toNonefor unknown types as opposed to return an error or panic or something. Additionally this looks like something that's better done in perhaps atranslate.rsorinline.rsstep? - For
let ty = ...this looks like it's doing a hash map lookup of a calculated type. Would it be possible to calculate that when the type is originally created early on intranslate.rsand/orinline.rsand then thread that through to here? For example I'd expect that this function here would havety: Option<SomeIndex>as an argument and then that's what's encoded into au32here.
There was a problem hiding this comment.
Agreed about the None default; I don't remember why I did that. I'll switch it to a panic.
And yes, I can move this code to an earlier stage, e.g. translate.rs or inline.rs.
Comment on lines
+386
to
+392
| let call = self.compiler.call_indirect_host( | ||
| &mut self.builder, | ||
| index, | ||
| host_sig, | ||
| host_fn, | ||
| &callee_args, | ||
| ); |
There was a problem hiding this comment.
Like above, the call_libcall helper might be able to help clean this up a little further
There was a problem hiding this comment.
Per my response above: I've already done this in a follow-up PR.
github-actions
bot
added
the
wasmtime:api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another piece of #9582 which I'm splitting out to make review easier.
This test exercises fused adapter generation for various flavors of intercomponent async->async, async->sync, and sync->async calls.
The remaining changes fill in some TODOs to make the test pass.