Disallow dead code/unused imports by default in wasmtime crate
#10108
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a change to the crate attributes of the `wasmtime` crate. Quite some time ago when Wasmtime had far fewer crate features I added a directive to allow dead code and unused imports when the `default` feature was disabled. The original intention was to not worry too much about unused imports and dead code in every possible configuration of Wasmtime to ease the burden of dealing with unused imports or compile-time conditionally used code. The primary consequence of this change though is that `cargo build` doesn't actually warn about dead code or unused imports in this repository during development. The reason for this is that the `default` feature is disabled by default and never actually enabled by any dependency inside the repository. Instead each crate, like `wasmtime-cli`, has its own `default` feature. If I were to start from the problem of "I want dead code warnings by default in this repository" there's two possible fixes: 1. Change `wasmtime-cli`'s `default` feature to include `wasmtime/default`. 2. Remove this `#[allow]` directive. While (1) would indeed work this is an attempt to get (2) working to see how bad the changes are necessary within the crate. prtest:full
|
Oof that's a lot of red |
github-actions
bot
added
the
wasmtime:api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a change to the crate attributes of the
wasmtimecrate. Quite some time ago when Wasmtime had far fewer crate features I added a directive to allow dead code and unused imports when thedefaultfeature was disabled. The original intention was to not worry too much about unused imports and dead code in every possible configuration of Wasmtime to ease the burden of dealing with unused imports or compile-time conditionally used code.The primary consequence of this change though is that
cargo builddoesn't actually warn about dead code or unused imports in this repository during development. The reason for this is that thedefaultfeature is disabled by default and never actually enabled by any dependency inside the repository. Instead each crate, likewasmtime-cli, has its owndefaultfeature.If I were to start from the problem of "I want dead code warnings by default in this repository" there's two possible fixes:
wasmtime-cli'sdefaultfeature to includewasmtime/default.#[allow]directive.While (1) would indeed work this is an attempt to get (2) working to see how bad the changes are necessary within the crate.
prtest:full