pulley: Expand provenance test some more #10112
Open
+183
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover more styles of function calls and a trap or two. This required fixing some issues with libcalls, notably ensuring that `expose_provenance()` is called at some point on the function pointers and additionally ensuring that the signedness of integer arguments were the same. The internal macro previously used `i32` and `i64` but that was actually used everywhere on the host as `u32` and `u64`. There was some confusion in some signatures so this commit fixes things to force everyone to use unsigned integers everywhere to match type we ascribe, the type it's defined with, and how it's called with Pulley.
github-actions
bot
added
wasmtime:api
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:api", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover more styles of function calls and a trap or two. This required fixing some issues with libcalls, notably ensuring that
expose_provenance()is called at some point on the function pointers and additionally ensuring that the signedness of integer arguments were the same. The internal macro previously usedi32andi64but that was actually used everywhere on the host asu32andu64. There was some confusion in some signatures so this commit fixes things to force everyone to use unsigned integers everywhere to match type we ascribe, the type it's defined with, and how it's called with Pulley.