refactor: no_std rustc_hash::{FxHashMap, FxHashSet} aliases
#9975
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKruckenberg
requested review from
cfallin
and removed request for
a team
bjorn3
reviewed
Jan 10, 2025
github-actions
bot
added
cranelift
cfallin
approved these changes
Jan 13, 2025
| use smallvec::{smallvec, SmallVec}; | ||
|
|
||
| #[cfg(not(feature = "std"))] | ||
| use crate::fx::FxHasher; | ||
| use rustc_hash::FxHasher; |
There was a problem hiding this comment.
It doesn't look like FxHasher or Hasher are used anywhere in this module, and they aren't exported -- can we remove them instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of
no_stdsupport in cranelift this PR fixes the usage ofrustc_hash::{FxHashMap, FxHashSet}which are not exported onno_stdtargets. It adds type aliases tolib.rssimilar to the already existingstd::collections::HashMapalias.