c#: Remove Copy of data during import call for base types (#1122)

* When calling an import we don't need to copy data to a new structure for cannoncal types. This avoid the extra copy of data in this scenario Signed-off-by: James Sturtevant <[email protected]> * Use a pinned gc handle to get a pointer to the list Using a span and fixed keyword won't work with variants due to the fact that the external import call requires different types. Nesting of the fixed commands also become unwiedly Signed-off-by: James Sturtevant <[email protected]> * Apply suggestions from code review Co-authored-by: Joel Dice <[email protected]> --------- Signed-off-by: James Sturtevant <[email protected]> Co-authored-by: Joel Dice <[email protected]>
bytecodealliance · Jan 16, 2025 · b0f6fd8 · b0f6fd8
1 parent 0bb8697
commit b0f6fd8
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/crates/csharp/src/function.rs b/crates/csharp/src/function.rs
@@ -723,21 +723,24 @@ impl Bindgen for FunctionBindgen<'_, '_> {
             }
 
             Instruction::ListCanonLower { element, realloc } => {
-                let list = &operands[0];
-                let (_size, ty) = list_element_info(element);
-
+                let list: &String = &operands[0];
                 match self.interface_gen.direction {
                     Direction::Import => {
-                        let buffer: String = self.locals.tmp("buffer");
+                        let ptr: String = self.locals.tmp("listPtr");
+                        let handle: String = self.locals.tmp("gcHandle");
+                        // Despite the name GCHandle.Alloc here this does not actually allocate memory on the heap. 
+                        // It pins the array with the garbage collector so that it can be passed to unmanaged code.
+                        // It is required to free the pin after use which is done in the Cleanup section.
                         uwrite!(
                             self.src,
                             "
-                            void* {buffer} = stackalloc {ty}[({list}).Length];
-                            {list}.AsSpan<{ty}>().CopyTo(new Span<{ty}>({buffer}, {list}.Length));
+                            var {handle} = GCHandle.Alloc({list}, GCHandleType.Pinned);
+                            var {ptr} = {handle}.AddrOfPinnedObject();
                             "
                         );
-                        results.push(format!("(int){buffer}"));
+                        results.push(format!("{ptr}")); 
                         results.push(format!("({list}).Length"));
+                        self.cleanup.push(Cleanup { address: handle });
                     }
                     Direction::Export => {
                         let address = self.locals.tmp("address");
@@ -1013,7 +1016,6 @@ impl Bindgen for FunctionBindgen<'_, '_> {
                             uwriteln!(self.src, "return ({results});")
                         }
                     }
-
                     // Close all the fixed blocks.
                     for _ in 0..self.fixed {
                         uwriteln!(self.src, "}}");
@@ -1103,7 +1105,7 @@ impl Bindgen for FunctionBindgen<'_, '_> {
 
                 match direction {
                     Direction::Import => {
-			let import_name = self.interface_gen.type_name_with_qualifier(&Type::Id(id), true);
+                        let import_name = self.interface_gen.type_name_with_qualifier(&Type::Id(id), true);
 
                         if let FunctionKind::Constructor(_) = self.kind {
                             resource = "this".to_owned();
@@ -1122,13 +1124,13 @@ impl Bindgen for FunctionBindgen<'_, '_> {
                     Direction::Export => {
                         self.interface_gen.csharp_gen.needs_rep_table = true;
 
-			let export_name = self.interface_gen.csharp_gen.all_resources[&id].export_impl_name();
+                        let export_name = self.interface_gen.csharp_gen.all_resources[&id].export_impl_name();
                         if is_own {
                             uwriteln!(
                                 self.src,
                                 "var {resource} = ({export_name}) {export_name}.repTable.Get\
-				     ({export_name}.WasmInterop.wasmImportResourceRep({op}));
-                                 {resource}.Handle = {op};"
+                                ({export_name}.WasmInterop.wasmImportResourceRep({op}));
+                                {resource}.Handle = {op};"
                             );
                         } else {
                             uwriteln!(self.src, "var {resource} = ({export_name}) {export_name}.repTable.Get({op});");