Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): enable submodules, remove upstream cachix action #4

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

eum3l
Copy link

@eum3l eum3l commented Jun 30, 2024

This PR fixes the broken workflows.
Versions after Nix v2.18.x seem to have a parsing bug (NixOS/nix#6633) with flakerefs.
Since cachix/install-nix-action uses v2.22.1, putting a # at the end of the flakeref fixes the submodule argument. Going back to v.2.18.x would also be an option.
The cargo-build.yml workflow now executes cargo build in a devShell with the dependencies of the package. This fixes outdated syntax.
I've also removed the workflow for the upstream cache.
If you want to add one for this project see Cachix and Nix CI with GitHub Actions.
The plugins are now also getting built with gtk4.
cargo-bump has been removed from cargo-update.yml, as it is no longer maintained and doesn't support workspaces.

@bzglve
Copy link
Owner

bzglve commented Jun 30, 2024

Awesome, thanks a lot <3
But I need to be sure
I've recently added glib schema as app state and moved default settings to /etc/xdg (XDG_CONFIG_DIRS)
Doesn't nix need to copy that like in install.sh do?

@eum3l
Copy link
Author

eum3l commented Jun 30, 2024

Awesome, thanks a lot <3 But I need to be sure I've recently added glib schema as app state and moved default settings to /etc/xdg (XDG_CONFIG_DIRS) Doesn't nix need to copy that like in install.sh do?

I fixed those with a refactor on eum3l/anyrun/fix-share.
Unfortunately it is based on this PR.
I'll make the new one, when this has been merged. :)

@bzglve
Copy link
Owner

bzglve commented Jul 1, 2024

I'm looking forward to it
Thanks a lot

@bzglve bzglve merged commit a4402a9 into bzglve:master Jul 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants