Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlsx-to-csv postprocess で*.xlsもcsvに変換できるようにする。 #90

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

champierre
Copy link
Contributor

@champierre champierre commented Oct 24, 2022

https://deno.land/x/[email protected]#xlsx によると xlsx -> csv 変換に使っている readXLSX および xlsx は SheetJS をベースとしており、https://docs.sheetjs.com/docs/miscellany/formats によると SheetJS は xls ファイルにも対応しているので、xlsx-to-csv のロジックそのままで *.xls も csv に変換できると知りました。

調布市観光施設一覧 のように、*.xls ファイルでオープンデータを公開している自治体も多いので、xlsx-to-csv で *.xls にも対応することを提案します。

関連 Issue: #83

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #90 (aa46704) into main (4c1ed68) will increase coverage by 4.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   94.77%   98.82%   +4.05%     
==========================================
  Files          18       18              
  Lines        1282     1282              
  Branches      132      134       +2     
==========================================
+ Hits         1215     1267      +52     
+ Misses         67       15      -52     
Impacted Files Coverage Δ
libs/postprocess/xlsx_to_csv_converter.ts 100.00% <100.00%> (ø)
libs/actions.ts 100.00% <0.00%> (+15.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ryo-ma
Copy link
Collaborator

ryo-ma commented Oct 24, 2022

素晴らしいです!
ありがとうございます!

@ryo-ma ryo-ma merged commit 770a23d into c-3lab:main Oct 24, 2022
@champierre champierre deleted the issue-83 branch October 24, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants