Add support for Epd2in13b v4 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-gilligan
force-pushed
the
epd2in13b_v4
branch
from
a8dd555 to
8e478b8
Compare
tommy-gilligan
commented
Feb 22, 2023
| fn test_tricolor_bitmask() { | ||
| assert_eq!( | ||
| TriColor::Black.bitmask(false, 0), | ||
| (0b01111111, u16::from_le_bytes([0b00000000, 0b00000000])) |
There was a problem hiding this comment.
using LE here so that it's bw buffer and then chromatic buffer
tommy-gilligan
force-pushed
the
epd2in13b_v4
branch
from
e11f17f to
43b887c
Compare
|
Hey @tommy-gilligan thanks for the work you did here. I just have a quick question. Does this code also work for waveshare 2in13 v4 (the black and white version)? Because I see there is not support for that particular device in edp-waveshare. |
|
The EPD that I have is black/white/red. This works for that but it sounds like you have black/white only? I'm not sure if it works for that but worth giving it a try IMHO. |
Amalgamation of waveshare/e-Paper code, datasheet PDF reference code and existing 2in13v2 driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #138 . I'm not too sure whether V4 makes sense as a separate driver or not. I did try getting V2 driver working with V4 display with as few as changes as possible. As far as I can tell, there are a few more changes involved for V3->V4 than there is V2->V3 but it doesn't rule out a shared driver.
I added some tests to help me understand TriColor better (but I don't know if they're super necessary).