initial snapshot does not define collation info #653
Conversation
rrd108
changed the title
| @@ -201,6 +201,7 @@ public function down(): void | |||
| $this->table('articles') | |||
| ->addColumn('content', 'text', [ | |||
| 'after' => 'rating', | |||
| 'collation' => 'utf8_general_ci', | |||
There was a problem hiding this comment.
I am still unsure about all these collation occurrences. One problem we have here is that we can't define a collation for the test schema, so I guess all the comparison tables will be created with the current server defaults.
Maybe the collation in the .lock files should be adapted accordingly to the test environment default, which I guess is utf8mb4_0900_ai_ci, so that the "default collation has not changed" behavior can be observed and tested properly.
There was a problem hiding this comment.
On the CI the default collation is set to utf8mb4_general_ci.
sudo service mysql start mysql -h 127.0.0.1 -u root -proot -e 'CREATE DATABASE cakephp_test DEFAULT COLLATE=utf8mb4_general_ci;
So that is why I had to add this wherever the test has a different collation.
This PR is intended to fix cakephp/phinx#2225
cleaned out for #645