Realistic benchmarks: Improve app configs #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extraBpmnModels need to configured not as one string (with comma separation), but with extra config parameter and array indices. For example: -Dapp.starter.extraBpmnModels.0="bpmn/realistic/refundingProcess.bpmn" -Dapp.starter.extraBpmnModels.1="bpmn/realistic/determineFraudRatingConfidence.dmn" -Dapp.starter.businessKey="customerId"
Process Id needs to be specified to determine which process is actually started Removing whitespace, as this broke the config
Add a new example values file that shows how to configure a benchmark with the intend to cover a realistic scenario
ChrisKujawa
force-pushed
the
ck-improve-app-configs
branch
from
5a335ba to
95d3ed2
Compare
deepthidevaki
approved these changes
Sep 9, 2024
Comment on lines
+19
to
+24
| # DEPRECATED worker configuration for the to be deployed worker application | ||
| worker: | ||
| # Worker.benchmark.replicas defines how many replicas of the benchmark worker should be deployed | ||
| replicas: 0 # disabled per default as it is deprecated | ||
| # Worker.benchmark.capacity defines how many jobs the worker should activate and work on | ||
| capacity: 60 |
There was a problem hiding this comment.
❓ If it is deprecated, can't it be removed?
There was a problem hiding this comment.
I thought we might want to still support the old approach, for other benchmarks, but I guess they can also use the old chart. I can remove it
Worker has been replaced with workers, where each worker can defined specifically. Notes have been adjusted to reflect this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the PR does
Example
Changes have be executed and deployed manually in our GKE.
Can be done via:
$ helm install zeebe-benchmark charts/zeebe-benchmark/ --render-subchart-notes -f charts/zeebe-benchmark/values-realistic-benchmark.yamlYou can port-forward to Operate to see process instances being executed
kubectl port-forward svc/zeebe-benchmark-operate 8081:80Furthermore, look at the Camunda Performance dashboard to observe the performance.