Allow injecting polling delay into worker deployment #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
force-pushed
the
np-inject-polling-delay
branch
from
ecd9ee5 to
6558b67
Compare
npepinpe
commented
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows injecting the polling delay into the worker deployment. The polling delay is given via command line as milliseconds because I couldn't be bothered to figure out how to convert to a nicer type from string 🙃
This will now allow us to "disable" polling for job push experiments.
It also fixes setting a default value for the worker Docker image tag, as it was previously defaulting to
""when omitted.