Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate zeebe's backup api from /backups to /backup-runtime #617

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat: migrate zeebe's backup api from /backups to /backup-runtime #617

merged 1 commit into from
Nov 19, 2024

Conversation

entangled90
Copy link
Contributor

Updates the actuator endpoints to match camunda/camunda#24456

closes #616

@entangled90 entangled90 self-assigned this Nov 18, 2024
@entangled90 entangled90 requested review from lenaschoenburg and removed request for ChrisKujawa November 18, 2024 14:07
lenaschoenburg
lenaschoenburg approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChrisKujawa
Copy link
Member

Hm not sure whether this will work? As we run our test against different versions? But I might oversee something @lenaschoenburg ?

@entangled90
Copy link
Contributor Author

Should I change the path depending on the version number?

@lenaschoenburg
Copy link
Member

As far as I know we have no automated tests so nothing should break. Detecting the right version would be fancy but I don't think it's strictly required.

@entangled90
Copy link
Contributor Author

I see that all other opened PR fail with the same error, should I proceed with the merge?

@lenaschoenburg
Copy link
Member

I'd say yes unless @Zelldon vetos.

@ChrisKujawa
Copy link
Member

As far as I know we have no automated tests so nothing should break. Detecting the right version would be fancy but I don't think it's strictly required.

Wouldnt the experiment itself break then?

@lenaschoenburg
Copy link
Member

Wouldnt the experiment itself break then?

Which experiment? I found none that made use of backups.

@ChrisKujawa
Copy link
Member

Hm? 🤔 I could swear we had one, but ok then nevermind. Then I guess we should add some

@entangled90 entangled90 merged commit 25fc215 into main Nov 19, 2024
2 of 3 checks passed
@entangled90 entangled90 deleted the cs-616-migrate-zeebes-backup-api-from-actuatorbacups-to-actuatorbackup-runtime branch November 19, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaschoenburg lenaschoenburg lenaschoenburg approved these changes

Assignees

@entangled90 entangled90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate zeebe's backup api from /actuator/bacups to /actuator/backup-runtime
3 participants
@entangled90 @ChrisKujawa @lenaschoenburg