Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nrobinaubertin committed Nov 29, 2023
1 parent e089683 commit 594be1c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,13 @@ def _on_config_changed(self, _: HookEvent) -> None:
Args:
event: Event triggering the config change handler.
"""
self._change_config()
self._configure_pod()

def _setup_and_activate(self) -> None:
"""Set up discourse, configure the pod and eventually activate the charm."""
if not self._is_setup_completed():
self._set_up_discourse()
self._change_config()
self._configure_pod()
if self._are_relations_ready():
self._activate_charm()

Expand Down Expand Up @@ -611,7 +612,7 @@ def _set_up_discourse(self) -> None:
logger.exception("Setting up discourse failed with code %d.", cmd_err.exit_code)
raise

def _change_config(self) -> None:
def _configure_pod(self) -> None:
"""Configure pod using pebble and layer generated from config.
Args:
Expand Down

0 comments on commit 594be1c

Please sign in to comment.