Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin plugins to specific commits #125

Merged
merged 13 commits into from
Oct 24, 2023
Merged

Pin plugins to specific commits #125

merged 13 commits into from
Oct 24, 2023

Conversation

nrobinaubertin
Copy link
Collaborator

@nrobinaubertin nrobinaubertin commented Oct 18, 2023

Overview

  • avoid surprise updates from transient dependencies or plugins
  • add the data-explorer plugin
  • upgrading nodejs version (because the old one failed to download)

This is accomplished by pinning all the plugins to a specific commit and forcing the bundler to respect the Gemfile.lock file without updating the gems.
The specific commit for each plugin was chosen according to the discourse-compatibility specification.

⚠️ This also disables the self-hosted github runners usage that are being flaky lately.

Checklist

@nrobinaubertin nrobinaubertin marked this pull request as ready for review October 24, 2023 02:44
@nrobinaubertin nrobinaubertin requested a review from a team as a code owner October 24, 2023 02:44
mthaddon
mthaddon previously approved these changes Oct 24, 2023
Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

weiiwang01
weiiwang01 previously approved these changes Oct 24, 2023
@nrobinaubertin nrobinaubertin dismissed stale reviews from weiiwang01 and mthaddon via 3b9b7a3 October 24, 2023 11:33
@github-actions
Copy link
Contributor

Test coverage for 6607a9d

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        303     34     86     17    87%   127, 129, 138, 140, 148-149, 289->294, 456, 468-470, 475, 486-488, 493, 505-507, 512, 524-526, 543-545, 585->exit, 592-593, 595->exit, 601, 629-635, 661->exit, 675-676, 686->exit, 700
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               333     35     94     18    88%

Static code analysis report

Run started:2023-10-24 16:54:23.955886

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1818
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrobinaubertin nrobinaubertin merged commit ba058cc into main Oct 24, 2023
29 checks passed
@nrobinaubertin nrobinaubertin deleted the pin-plugins branch October 24, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants