Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use juju 3 in integ tests #143

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Use juju 3 in integ tests #143

merged 8 commits into from
Dec 1, 2023

Conversation

nrobinaubertin
Copy link
Collaborator

@nrobinaubertin nrobinaubertin commented Nov 21, 2023

Overview

Adapt integration tests to run on juju 3.

Checklist

Copy link
Contributor

Test coverage for 4daf4ac

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        324     32     84     12    89%   137, 163, 173, 181-182, 338->343, 526-528, 533-534, 545-547, 552-553, 565-567, 572-573, 585-587, 612-614, 654->exit, 664->exit, 694-700, 726->exit, 740-741, 751->exit, 765
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               354     33     92     13    90%

Static code analysis report

Run started:2023-11-30 20:57:16.134030

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1905
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@nrobinaubertin nrobinaubertin marked this pull request as ready for review November 30, 2023 23:14
@nrobinaubertin nrobinaubertin requested a review from a team as a code owner November 30, 2023 23:14
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrobinaubertin nrobinaubertin merged commit 50fe26e into main Dec 1, 2023
28 checks passed
@nrobinaubertin nrobinaubertin deleted the juju-3 branch December 1, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants